[SYCL] Forward decl free func kernel template args#21285
Open
KornevNikita wants to merge 6 commits intointel:syclfrom
Open
[SYCL] Forward decl free func kernel template args#21285KornevNikita wants to merge 6 commits intointel:syclfrom
KornevNikita wants to merge 6 commits intointel:syclfrom
Conversation
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
approved these changes
Feb 18, 2026
dklochkov-emb
approved these changes
Feb 18, 2026
lbushi25
approved these changes
Feb 18, 2026
tahonermann
suggested changes
Feb 18, 2026
clang/test/CodeGenSYCL/free_function_default_template_arguments.cpp
Outdated
Show resolved
Hide resolved
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
tahonermann
approved these changes
Feb 18, 2026
Contributor
tahonermann
left a comment
tahonermann
left a comment
There was a problem hiding this comment.
Adding my approval with a comment regarding additional tests that I think would be useful.
| // CHECK-NEXT: template <typename scalar_t, typename F> void templated(scalar_t *); | ||
| // CHECK-NEXT: static constexpr auto __sycl_shim1() { | ||
| // CHECK-NEXT: return (void (*)(float *))templated<float, struct TestStruct<float>>; | ||
| // CHECK-NEXT: } |
Contributor
There was a problem hiding this comment.
Thanks for moving the test declarations to a new test file. This suffices for the reported issue, so I'll accept the review.
If you aren't opposed, here are some other cases that I think would be useful to test.
template <auto V>
[[__sycl_detail__::add_ir_attributes_function("sycl-nd-range-kernel", 1)]]
void ffk1() {
}
template <typename> struct TestClassTemplate1 {
};
struct TestClass1;
template void ffk1<TestClassTemplate1<TestClass1>{}>();
template <typename T, template<typename> class CT>
[[__sycl_detail__::add_ir_attributes_function("sycl-nd-range-kernel", 1)]]
void ffk2(CT<T>) {}
template <typename> struct TestClassTemplate2 {
};
struct TestClass2;
template void ffk2(TestClassTemplate2<TestClass2>);
Contributor
Author
There was a problem hiding this comment.
Thanks. Sure, additional tests are always welcome. But this patch got a bunch of approvals and additional test cases may unveil some additional issues, so I will proceed with merging this one and creating a follow-up patch to not bother approvers with another round of review here.
Contributor
Author
|
@uditagarwal97 take a look please, just an E2E test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMPLRLLVM-72459
This patch fixes compilation error that occur when a free function kernel has a template parameter.
Visit and forward declare template args of free functions kernels.